test: add coverage for Expr overhead system and fix docs#100
Merged
Conversation
…fix docs - Add 12 tests for Expr: fractional display, Log/Sqrt display, Mul/Pow parenthesization, missing variable eval, scale, ops::Add, substitute and variables for Exp/Log/Sqrt branches - Add test_size_getters to all 19 model test files covering new inherent getter methods (num_vertices, num_edges, num_vars, num_constraints, num_interactions, num_literals, universe_size, m, n, num_variables, num_bits_first, num_bits_second, num_sequence, rank) - Update docs/src/design.md: replace poly!() examples with Expr syntax - Update skills (add-model, add-rule, review-implementation): remove references to deleted problem_size_names/problem_size_values methods - Update issue templates: reference inherent getter methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 96.46% 96.90% +0.43%
==========================================
Files 196 196
Lines 26620 26811 +191
==========================================
+ Hits 25679 25980 +301
+ Misses 941 831 -110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exprdisplay/eval branches (fractional constants, Log/Sqrt display, Mul/Pow parenthesization, missing variable eval)test_size_gettersto all 19 model test files covering new inherent getter methods added in Replace Polynomial overhead system with Expr AST #99poly!()references with newExprstring-based syntaxproblem_size_names/problem_size_valuestrait methodsFollows up on #99 which was merged before these coverage/doc fixes were pushed.
Test plan
make checkpasses (fmt + clippy + test)🤖 Generated with Claude Code